Skip to content

Comments

Allow the use of pyfive.Dataset for interface_type https as well#309

Merged
valeriupredoi merged 4 commits intomainfrom
use_dataset_for_https
Feb 23, 2026
Merged

Allow the use of pyfive.Dataset for interface_type https as well#309
valeriupredoi merged 4 commits intomainfrom
use_dataset_for_https

Conversation

@valeriupredoi
Copy link
Collaborator

@valeriupredoi valeriupredoi commented Feb 20, 2026 •
edited
Loading

Description

Small wiggle that I didn't consider in #300
Needs NCAS-CMS/pyfive#197 for all tests to pass.

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • If you are working on the documentation, please ensure the current build passes
  • All tests pass

@valeriupredoi valeriupredoi added the enhancement New feature or request label Feb 20, 2026
@valeriupredoi
Copy link
Collaborator Author

valeriupredoi commented Feb 20, 2026

NCAS-CMS/pyfive#197 has now been merged (with many thanks to @davidhassell for the review) so I'll pop a new bugfix release of Pyfive on Monday, merging this now since I tested it with the new pyfive/main and all's OK 🍻

@valeriupredoi valeriupredoi merged commit dd0da7d into main Feb 23, 2026
1 of 3 checks passed
@valeriupredoi valeriupredoi deleted the use_dataset_for_https branch February 23, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@valeriupredoi